Revision history for DreckFehler


Revision [23279]

Last edited on 2016-05-20 07:38:47 by JavaWoman [Replaces old-style internal links with new pipe-split links.]
Additions:
driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage | mindWiki]]""<!-- via the web archive, no styling -->"", i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)
""<!--[[http://mindwiki.de/sebastian/mail | contact form]] no longer functional-->""
- GroupManagement (a [[http://www.wakkawiki.com/WakkaAliases | clever patch]] written by VictorManuelVarela needs some slight improvements.
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[RedirectingPages | redirector feature]] and redirects from the old page to the moved one to keep the links still working)
Deletions:
driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]]""<!-- via the web archive, no styling -->"", i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)
""<!--[[http://mindwiki.de/sebastian/mail contact form]] no longer functional-->""
- GroupManagement (a [[http://www.wakkawiki.com/WakkaAliases clever patch]] written by VictorManuelVarela needs some slight improvements.
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[RedirectingPages redirector feature]] and redirects from the old page to the moved one to keep the links still working)

Revision [19308]

Edited on 2008-01-28 00:14:45 by JavaWoman [Modified links pointing to docs server]

No Differences

Revision [17244]

Edited on 2007-07-08 05:40:20 by JavaWoman [fixing link for "redirector feature"]
Additions:
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[RedirectingPages redirector feature]] and redirects from the old page to the moved one to keep the links still working)
Deletions:
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[Move Pages redirector feature]] and redirects from the old page to the moved one to keep the links still working)

Revision [17243]

Edited on 2007-07-08 05:34:59 by JavaWoman [fixed another interwiki link to Wakka]
Additions:
- GroupManagement (a [[http://www.wakkawiki.com/WakkaAliases clever patch]] written by VictorManuelVarela needs some slight improvements.
Deletions:
- GroupManagement (a [[WakkaWiki:WakkaAliases clever patch]] written by VictorManuelVarela needs some slight improvements.

Revision [10264]

Edited on 2005-07-30 16:00:58 by JavaWoman [adding heading to avoid confusion]
Additions:
=====DreckFehler=====

Revision [10259]

Edited on 2005-07-30 07:38:47 by JavaWoman [fixing link t point to the webarchive version (no styling): mindWiki is dead]
Additions:
driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]]""<!-- via the web archive, no styling -->"", i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)
""<!--[[http://mindwiki.de/sebastian/mail contact form]] no longer functional-->""
Deletions:
driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]], i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)
[[http://mindwiki.de/sebastian/mail contact form]]

Revision [10255]

Edited on 2005-07-30 00:40:25 by VictorManuelVarela [fixing link t point to the webarchive version (no styling): mindWiki is dead]
Additions:
**dreckfehler** was my eZine (which is laid asleep for several reasons but may be reanimated some day) and it hosted my very first wiki. it's also a german spun. the word (correctly spelled dr**u**ckfehler) means "type mismatch" but even with a type mismatch in it.

if that explanation confuses you, you can go with cockney rebel and call me sebastian ;)

driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]], i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)

as i haven't managed it yet to rewrite the install routine of mindWiki (and most of the time new changes are swifter than tracking these modifications to keep the installation alive) i decided to leave the bothersome duty to maintain the code to jason (who does an excellent job!) and contribute enhancements to wikka when i see them fit for public (and if i remember what lines exactly have to be tweaked in the code)

[[http://mindwiki.de/sebastian/mail contact form]]

===work in progress===
- PageWatches (this too is already done by a wakka modification)

===contributions to wikka:===
- WikiPing (though already implemented in wikka 1.1.3.3 this may be still an object to changes)
- SafePagePurging
- BugfixListFormatter
- IncludeAction
- GroupManagement (a [[WakkaWiki:WakkaAliases clever patch]] written by VictorManuelVarela needs some slight improvements.
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[Move Pages redirector feature]] and redirects from the old page to the moved one to keep the links still working)
- DreckfehlerArchive (a couple of patches which are now part of wikka and thus not worth a closer look)

----
{{backlinks}}
Deletions:
**dreckfehler** was my eZine (which is laid asleep for several reasons but may be reanimated some day) and it hosted my very first wiki. it's also a german spun. the word (correctly spelled dr**u**ckfehler) means "type mismatch" but even with a type mismatch in it.

if that explanation confuses you, you can go with cockney rebel and call me sebastian ;)

driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]], i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)

as i haven't managed it yet to rewrite the install routine of mindWiki (and most of the time new changes are swifter than tracking these modifications to keep the installation alive) i decided to leave the bothersome duty to maintain the code to jason (who does an excellent job!) and contribute enhancements to wikka when i see them fit for public (and if i remember what lines exactly have to be tweaked in the code)

[[http://mindwiki.de/sebastian/mail contact form]]

===work in progress===
- PageWatches (this too is already done by a wakka modification)

===contributions to wikka:===
- WikiPing (though already implemented in wikka 1.1.3.3 this may be still an object to changes)
- SafePagePurging
- BugfixListFormatter
- IncludeAction
- GroupManagement (a [[WakkaWiki:WakkaAliases clever patch]] written by [[http://www.wakkawiki.com/VictorManuelVarela victor manuel varela]] needs some slight improvements.
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[Move Pages redirector feature]] and redirects from the old page to the moved one to keep the links still working)
- DreckfehlerArchive (a couple of patches which are now part of wikka and thus not worth a closer look)

----
{{backlinks}}


Revision [2050]

Edited on 2004-10-29 19:47:54 by NilsLindenberg [category added]

No Differences

Revision [2049]

Edited on 2004-10-29 19:47:40 by NilsLindenberg [category added]
Additions:
{{backlinks}}
CategoryUsers
Deletions:
{{backlinks}}

Revision [1762]

Edited on 2004-10-09 01:29:58 by DavidCollantes [Added backlinks]
Additions:
- PageWatches (this too is already done by a wakka modification)
- WikiPing (though already implemented in wikka 1.1.3.3 this may be still an object to changes)
- SafePagePurging
- BugfixListFormatter
- IncludeAction
- GroupManagement (a [[WakkaWiki:WakkaAliases clever patch]] written by [[http://www.wakkawiki.com/VictorManuelVarela victor manuel varela]] needs some slight improvements.
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[Move Pages redirector feature]] and redirects from the old page to the moved one to keep the links still working)
- DreckfehlerArchive (a couple of patches which are now part of wikka and thus not worth a closer look)
----
{{backlinks}}
Deletions:
- PageWatches (this too is already done by a wakka modification)
- WikiPing (though already implemented in wikka 1.1.3.3 this may be still an object to changes)
- SafePagePurging
- BugfixListFormatter
- IncludeAction
- GroupManagement (a [[WakkaWiki:WakkaAliases clever patch]] written by [[http://www.wakkawiki.com/VictorManuelVarela victor manuel varela]] needs some slight improvements.
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[Move Pages redirector feature]] and redirects from the old page to the moved one to keep the links still working)
- DreckfehlerArchive (a couple of patches which are now part of wikka and thus not worth a closer look)

Revision [1031]

Edited on 2004-08-19 00:21:19 by DreckFehler [cleaned up]
Additions:
- MovePages (mindwiki actually doesn't adjust every link all over the wiki but adds a [[Move Pages redirector feature]] and redirects from the old page to the moved one to keep the links still working)
Deletions:
- MoveHandler (mindwiki actually doesn't adjust every link all over the wiki but adds a redirector feature and redirects from the old page to the moved one to keep the links still working)

Revision [1011]

Edited on 2004-08-16 00:16:29 by DreckFehler [link to group management]
Additions:
- GroupManagement (a [[WakkaWiki:WakkaAliases clever patch]] written by [[http://www.wakkawiki.com/VictorManuelVarela victor manuel varela]] needs some slight improvements.
Deletions:
- WakkaAliases (a clever patch written by [[http://www.wakkawiki.com/VictorManuelVarela victor manuel varela]] needs some slight improvements.

Revision [993]

Edited on 2004-08-14 23:27:48 by DreckFehler [added include action]
Additions:
- IncludeAction

Revision [984]

Edited on 2004-08-14 18:21:56 by DreckFehler [garbage collection, part two]
Additions:
**dreckfehler** was my eZine (which is laid asleep for several reasons but may be reanimated some day) and it hosted my very first wiki. it's also a german spun. the word (correctly spelled dr**u**ckfehler) means "type mismatch" but even with a type mismatch in it.

if that explanation confuses you, you can go with cockney rebel and call me sebastian ;)

driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]], i have been fallen in love with the straight, compact code that wakkawiki (and wikka aswell) provides ;)

as i haven't managed it yet to rewrite the install routine of mindWiki (and most of the time new changes are swifter than tracking these modifications to keep the installation alive) i decided to leave the bothersome duty to maintain the code to jason (who does an excellent job!) and contribute enhancements to wikka when i see them fit for public (and if i remember what lines exactly have to be tweaked in the code)

[[http://mindwiki.de/sebastian/mail contact form]]

===work in progress===
- WakkaAliases (a clever patch written by [[http://www.wakkawiki.com/VictorManuelVarela victor manuel varela]] needs some slight improvements.
- PageWatches (this too is already done by a wakka modification)
- MoveHandler (mindwiki actually doesn't adjust every link all over the wiki but adds a redirector feature and redirects from the old page to the moved one to keep the links still working)

===contributions to wikka:===
- WikiPing (though already implemented in wikka 1.1.3.3 this may be still an object to changes)
- SafePagePurging
- BugfixListFormatter
- DreckfehlerArchive (a couple of patches which are now part of wikka and thus not worth a closer look)
Deletions:
driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]], i have been fallen in love with the straight, compact code ;)

[[http://mindwiki.de/sebastian/mail contact form]]

the following hacks and tweaks are based on WakkaWiki v. 1.2 (unless stated otherwisse). try to figure out yourself, where to put the changes in modified code ;)
----
=====discussion=====
if the config-value "pages_purge_time" is set to another value than zero (never purge), //any// revision will be deleted if a page is untouched for a while and modified after a period greater than the purge-time. due to this it's possible to destroy old pages which aren't modified frequently without any chance to recover it.

this flaw may be covered by the mechanism used in wikka wiki to mark minor changes as non cacheble and only cleanup only those pages(?). if not, there shold be a more sophisticated use of purging in the function $wakka->maintenance. any ideas?

''Yes, this is good discussion item. Personally, I've never used "pages_purge_time", and had not given it much thought. It seems that we need another option such as purge_keep_limit, which will specify that at least x number of page revisions should be kept. What do you think? -- JsnX''

ok, let's give it a try:

first alter the pages-table like this:

%%ALTER TABLE `wakka_pages` CHANGE `latest` `latest` ENUM( 'N', 'Y', 'B' ) DEFAULT 'N' NOT NULL%%

then refer to the $wakka-savepage() function and look for the following line:

%%(php)<?php
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'N' where tag = '".mysql_Escape_string($tag)."'");
?>%%

and expand it to this:

%%(php)<?php
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'N' where tag = '".mysql_Escape_string($tag)."'"); // unchanged, it sets all "b"-flagged rows to "n"
if ($threshold = $this->LoadSingle("select * from ".$this->config["table_prefix"]."pages where tag ='".mysql_Escape_string($tag)."' order by time desc limit 10,1")) { // maybe its better to use a variable like $wakka->config["keep_revisions"] for the "limit"-clause
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'B' where tag = '".mysql_Escape_string($tag)."' and time > '".$threshold["time"]."'");
} else {
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'B' where tag = '".mysql_Escape_string($tag)."'");
}
?>%%

looks ugly ;)

for mysql [[http://dev.mysql.com/doc/mysql/en/UPDATE.html version 4.0.0]] and later the following should fit:

%%(php)<?php
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'N' where tag = '".mysql_Escape_string($tag)."'");
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'B' where tag = '".mysql_Escape_string($tag)."' order by time desc limit 10");
?>%%

leave the maintenance-function as is. it will treat only the "n"-flagged rows as usual. with every new revision the save-function will determine which versions should be protected by changing the flag to "b"
----
=====ready-to-use modifications:=====
====bug in rendering of lists====
if a list - ordered or unordered - is put at the very begining of a page (i.e. there is no text before that list), the first item of the list will not be recognized as a list-member, because the body is trimmed before saving. the bug is located in the function $wakka->savePage().

change this code-snippet

%%(php)// add new revision
$this->Query("insert into ".$this->config["table_prefix"]."pages set ".
"tag = '".mysql_escape_string($tag)."', ".
($comment_on ? "comment_on = '".mysql_escape_string($comment_on)."', " : "").
"time = now(), ".
"owner = '".mysql_escape_string($owner)."', ".
"user = '".mysql_escape_string($user)."', ".
"latest = 'Y', ".
"body = '".mysql_escape_string(trim($body))."'");
%%

to this one

%%(php)// add new revision
if (preg_match("/^([\t]+)(-|([1aiAI]\))?)/", $body, $matches)) $lead = $matches[1]; // save tab(s) of first list-definition, if any at the begining
$body = $lead.trim($body); //and write it back to the trimmed body

$this->Query("insert into ".$this->config["table_prefix"]."pages set ".
"tag = '".mysql_escape_string($tag)."', ".
($comment_on ? "comment_on = '".mysql_escape_string($comment_on)."', " : "").
"time = now(), ".
"owner = '".mysql_escape_string($owner)."', ".
"user = '".mysql_escape_string($user)."', ".
"latest = 'Y', ".
"body = '".mysql_escape_string($body)."'"); // <<<<<<< trim() removed! we did it already
%%

wikkawiki trims the body again, when it checks for changes in the **edit.php** before saving. so we have to do the same tweak there (otherwise nothing serious would happen, wikka would just save unchanged pages when they start with a list)

%%(php)<?php
// only save if new body differs from old body
if (preg_match("/^([\t ]+)(-|([1aiAI]\))?)/", $body, $matches)) $lead = $matches[1]; // <<<<<<<<<<<< insert this line
if ($lead.trim($body) != $this->page['body']) { // <<<<<<<<<<<< and the $lead in front of the actual body
?>%%
====bug in formatter: forced links in square brackets====
[''Note: Forced links in square brackets is now fixed in Wikka by default starting with Wikka 1.1.3.1, thanks to Dreck.'']
think about a ""[[forced link]]"" set into square brackets like this: ""[""[[dreckfehler]]]. it wouldn't work without a trick, because wakkawiki don't know how to deal with three subsequent brackets. obviously it should render the innermost brackets but it takes the leftmost. to solve this behaviour we have to assure that the formatter uses only those opening brackets which are not followed by more square brackets. refer to the formatters/wakka.php and look for the huge regular expression which is stored in the variable $text and steers the parsing-process. change the line dealing with the forced links

the old version:
%%(php)<?php
"\[\[.*?\]\]|".
?>%%

and the new one:

%%(php)<?php
"\[\[[^\[].*?\]\]|".
?>%%

and you're done. the corresponding regex within the callback-function doesn't need any changes, because it will never get three subsequent opening brackets to match.

====unnamed parameters====
===action googleform===
[''Note: The googleform action is now in Wikka by default starting with Wikka 1.1.3.1, thanks to Dreck.'']

little stupid example for the unnamed parameters below ;) but it's sometimes quite useful. i leave such a googleform on every page that is considered "under construction". this gives me quick access to further research on a topic.

%%(php)<?php if (!$q) $q = $this->tag(); ?>

<p><FORM action="http://www.google.com/search" method=get name=f target=_blank>
<INPUT type=text value='<?=$q ?>' framewidth='4' name='q' size='30'> <INPUT name='btnG' type='submit' value='Google'>
</FORM>%%

save this snippet as "googleform.php" in the actions-folder. after that you can call anywhere ""{{googleform}}"" to show a searchform which is preset with the page-title. if you want to offer another search-term as default, call ""{{googleform q="wikkawiki"}}"".

===unnamed parameters===

[''Note: The unnamed parameters modification is now in Wikka by default starting with Wikka 1.1.3.1, many thanks to Dreck.'']

lots of actions need only one parameter and there is no need to distinguish it from others. additionally in some cases (like the googleform above) quotation marks are useful within the parameter, which isn't recognized by the action-api. the solution is to define an extra variable that contains the whole parameterstring. the old mechanism to pass over parameters (i.e. var_name="value") will still work.

we need to modify the function $wakka->Action():

old version (wikkawiki v. 1.1.3):

%%(php)<?php
// stupid attributes check
if (stristr($action, "=\"")) {
// extract $action and $vars_temp ("raw" attributes)
preg_match("/^([A-Za-z0-9]*)(.*)$/", $action, $matches);
list(, $action, $vars_temp) = $matches;

// match all attributes (key and value)
preg_match_all("/([A-Za-z0-9]*)=\"(.*)\"/U", $vars_temp, $matches);

// prepare an array for extract() to work with (in $this->IncludeBuffered())
if (is_array($matches)) {
for ($a = 0; $a < count($matches[0]); $a++) {
$vars[$matches[1][$a]] = $matches[2][$a];
// ?? $vars[$a] = $matches[2][$a];
}
}
}
?>%%

modify it as follows:

%%(php)<?php
// stupid attributes check
// if (stristr($action, "=\"")) { <<<<<<< this is not needed, we'll do this check in the following preg_match
// extract $action and $vars_temp ("raw" attributes)
if (preg_match("/^([A-Za-z0-9]*)\s+(.*)$/", $action, $matches);) { // <<<<<<< treat everything after the first whitespace as parameter
list(, $action, $vars_temp) = $matches;
if (!$action) return "<span class='error'><i>unknown action, the action-name must not contain special chars!</i></span>"; // <<<<<<< the pattern ([A-Za-z0-9])\s+ didn't match!

// match all attributes (key and value)
preg_match_all("/([A-Za-z0-9]*)=\"(.*)\"/U", $vars_temp, $matches);

// prepare an array for extract() to work with (in $this->IncludeBuffered())
if (is_array($matches)) {
for ($a = 0; $a < count($matches[0]); $a++) {
$vars[$matches[1][$a]] = $matches[2][$a];
}
}
$vars["wakka_vars"] = trim($vars_temp); // <<<<<<< add the buffered parameter-string to the array
}
?>%%

now we can refer to the whole parameter-string in $wakka_vars even if it doesn't follow the pattern **var="value" ...** how to treat this feature belongs to the actions itself.

let's have a look at the googleform-action from above:

%%(php)<?php
if (!$q) { //leave the old syntax untouched. you may omit this if-clause when you never used the former action-call (or want to change every appereance of it in your wiki ;) )
if ($wakka_vars) $q = $wakka_vars;
else $q = $this->tag();
}
?>

<p><FORM action="http://www.google.com/search" method=get name=f target=_blank>
<INPUT type=text value='<?=$q ?>' framewidth='4' name='q' size='30'> <INPUT name='btnG' type='submit' value='Google'>
</FORM>%%

now you can offer a more convinient syntax: ""{{googleform searchstring}}"". even double-quotes are passed to the input field, i.e. ""{{googleform "search phrase"}}"" will search for a connected phrase instead of two separate words.

Revision [842]

Edited on 2004-08-01 16:20:20 by JsnX [garbage collection, part two]
Additions:
[''Note: The unnamed parameters modification is now in Wikka by default starting with Wikka 1.1.3.1, many thanks to Dreck.'']

Revision [841]

Edited on 2004-08-01 15:49:59 by JsnX [garbage collection, part two]
Additions:
[''Note: Forced links in square brackets is now fixed in Wikka by default starting with Wikka 1.1.3.1, thanks to Dreck.'']
[''Note: The googleform action is now in Wikka by default starting with Wikka 1.1.3.1, thanks to Dreck.'']

Revision [795]

Edited on 2004-07-28 19:55:37 by DreckFehler [bugfix for lists enhanced, new bugfix for forced l]
Additions:
wikkawiki trims the body again, when it checks for changes in the **edit.php** before saving. so we have to do the same tweak there (otherwise nothing serious would happen, wikka would just save unchanged pages when they start with a list)
// only save if new body differs from old body
if (preg_match("/^([\t ]+)(-|([1aiAI]\))?)/", $body, $matches)) $lead = $matches[1]; // <<<<<<<<<<<< insert this line
if ($lead.trim($body) != $this->page['body']) { // <<<<<<<<<<<< and the $lead in front of the actual body
====bug in formatter: forced links in square brackets====
think about a ""[[forced link]]"" set into square brackets like this: ""[""[[dreckfehler]]]. it wouldn't work without a trick, because wakkawiki don't know how to deal with three subsequent brackets. obviously it should render the innermost brackets but it takes the leftmost. to solve this behaviour we have to assure that the formatter uses only those opening brackets which are not followed by more square brackets. refer to the formatters/wakka.php and look for the huge regular expression which is stored in the variable $text and steers the parsing-process. change the line dealing with the forced links
the old version:
"\[\[.*?\]\]|".
and the new one:
"\[\[[^\[].*?\]\]|".
and you're done. the corresponding regex within the callback-function doesn't need any changes, because it will never get three subsequent opening brackets to match.

Revision [786]

Edited on 2004-07-27 23:02:11 by DreckFehler [maintenance-code, unnamed parameters for actions]
Additions:
the following hacks and tweaks are based on WakkaWiki v. 1.2 (unless stated otherwisse). try to figure out yourself, where to put the changes in modified code ;)
ok, let's give it a try:
first alter the pages-table like this:
%%ALTER TABLE `wakka_pages` CHANGE `latest` `latest` ENUM( 'N', 'Y', 'B' ) DEFAULT 'N' NOT NULL%%
then refer to the $wakka-savepage() function and look for the following line:
%%(php)<?php
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'N' where tag = '".mysql_Escape_string($tag)."'");
?>%%
and expand it to this:
%%(php)<?php
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'N' where tag = '".mysql_Escape_string($tag)."'"); // unchanged, it sets all "b"-flagged rows to "n"
if ($threshold = $this->LoadSingle("select * from ".$this->config["table_prefix"]."pages where tag ='".mysql_Escape_string($tag)."' order by time desc limit 10,1")) { // maybe its better to use a variable like $wakka->config["keep_revisions"] for the "limit"-clause
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'B' where tag = '".mysql_Escape_string($tag)."' and time > '".$threshold["time"]."'");
} else {
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'B' where tag = '".mysql_Escape_string($tag)."'");
}
?>%%
looks ugly ;)
for mysql [[http://dev.mysql.com/doc/mysql/en/UPDATE.html version 4.0.0]] and later the following should fit:
%%(php)<?php
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'N' where tag = '".mysql_Escape_string($tag)."'");
$this->Query("update ".$this->config["table_prefix"]."pages set latest = 'B' where tag = '".mysql_Escape_string($tag)."' order by time desc limit 10");
?>%%
leave the maintenance-function as is. it will treat only the "n"-flagged rows as usual. with every new revision the save-function will determine which versions should be protected by changing the flag to "b"
=====ready-to-use modifications:=====
====unnamed parameters====
===action googleform===
little stupid example for the unnamed parameters below ;) but it's sometimes quite useful. i leave such a googleform on every page that is considered "under construction". this gives me quick access to further research on a topic.
%%(php)<?php if (!$q) $q = $this->tag(); ?>
<p><FORM action="http://www.google.com/search" method=get name=f target=_blank>
<INPUT type=text value='<?=$q ?>' framewidth='4' name='q' size='30'> <INPUT name='btnG' type='submit' value='Google'>
</FORM>%%
save this snippet as "googleform.php" in the actions-folder. after that you can call anywhere ""{{googleform}}"" to show a searchform which is preset with the page-title. if you want to offer another search-term as default, call ""{{googleform q="wikkawiki"}}"".
===unnamed parameters===
lots of actions need only one parameter and there is no need to distinguish it from others. additionally in some cases (like the googleform above) quotation marks are useful within the parameter, which isn't recognized by the action-api. the solution is to define an extra variable that contains the whole parameterstring. the old mechanism to pass over parameters (i.e. var_name="value") will still work.
we need to modify the function $wakka->Action():
old version (wikkawiki v. 1.1.3):
%%(php)<?php
// stupid attributes check
if (stristr($action, "=\"")) {
// extract $action and $vars_temp ("raw" attributes)
preg_match("/^([A-Za-z0-9]*)(.*)$/", $action, $matches);
list(, $action, $vars_temp) = $matches;
// match all attributes (key and value)
preg_match_all("/([A-Za-z0-9]*)=\"(.*)\"/U", $vars_temp, $matches);
// prepare an array for extract() to work with (in $this->IncludeBuffered())
if (is_array($matches)) {
for ($a = 0; $a < count($matches[0]); $a++) {
$vars[$matches[1][$a]] = $matches[2][$a];
// ?? $vars[$a] = $matches[2][$a];
}
}
}
?>%%
modify it as follows:
%%(php)<?php
// stupid attributes check
// if (stristr($action, "=\"")) { <<<<<<< this is not needed, we'll do this check in the following preg_match
// extract $action and $vars_temp ("raw" attributes)
if (preg_match("/^([A-Za-z0-9]*)\s+(.*)$/", $action, $matches);) { // <<<<<<< treat everything after the first whitespace as parameter
list(, $action, $vars_temp) = $matches;
if (!$action) return "<span class='error'><i>unknown action, the action-name must not contain special chars!</i></span>"; // <<<<<<< the pattern ([A-Za-z0-9])\s+ didn't match!
// match all attributes (key and value)
preg_match_all("/([A-Za-z0-9]*)=\"(.*)\"/U", $vars_temp, $matches);
// prepare an array for extract() to work with (in $this->IncludeBuffered())
if (is_array($matches)) {
for ($a = 0; $a < count($matches[0]); $a++) {
$vars[$matches[1][$a]] = $matches[2][$a];
}
}
$vars["wakka_vars"] = trim($vars_temp); // <<<<<<< add the buffered parameter-string to the array
}
?>%%
now we can refer to the whole parameter-string in $wakka_vars even if it doesn't follow the pattern **var="value" ...** how to treat this feature belongs to the actions itself.
let's have a look at the googleform-action from above:
%%(php)<?php
if (!$q) { //leave the old syntax untouched. you may omit this if-clause when you never used the former action-call (or want to change every appereance of it in your wiki ;) )
if ($wakka_vars) $q = $wakka_vars;
else $q = $this->tag();
}
?>
<p><FORM action="http://www.google.com/search" method=get name=f target=_blank>
<INPUT type=text value='<?=$q ?>' framewidth='4' name='q' size='30'> <INPUT name='btnG' type='submit' value='Google'>
</FORM>%%
now you can offer a more convinient syntax: ""{{googleform searchstring}}"". even double-quotes are passed to the input field, i.e. ""{{googleform "search phrase"}}"" will search for a connected phrase instead of two separate words.
Deletions:
the following hacks and tweaks are based on WakkaWiki v. 1.2. try to figure out yourself, where to put the changes in modified code ;)
that is not as trivial as it seems. or am i too stupid? ;) with mysql-versions //prior to 4.0// you can't order the table by a field (here the timestamp) to make a limit-clause work correctly in a delete-statement. i ran into the same prob with an update-statement which should set the "latest"-field of the most recent 10 rows to "b" (for backup) when saving and only delete those rows, that are flagged with a "n". that would have been the solution to treat each tag individually, as necessary.
i haven't tried a solution, which does a select on the tenth row fetching the "time"-field and do (in a second query) an update which flags all rows as "b" that are newer as the timestamp fetched before (all this in the save-function). but this looks a bit cumbersome to me. ~~~
=====ready-to-use modifications=====

Revision [765]

Edited on 2004-07-24 21:24:55 by DreckFehler [pages-purge-time revised]
Additions:
that is not as trivial as it seems. or am i too stupid? ;) with mysql-versions //prior to 4.0// you can't order the table by a field (here the timestamp) to make a limit-clause work correctly in a delete-statement. i ran into the same prob with an update-statement which should set the "latest"-field of the most recent 10 rows to "b" (for backup) when saving and only delete those rows, that are flagged with a "n". that would have been the solution to treat each tag individually, as necessary.
i haven't tried a solution, which does a select on the tenth row fetching the "time"-field and do (in a second query) an update which flags all rows as "b" that are newer as the timestamp fetched before (all this in the save-function). but this looks a bit cumbersome to me. ~~~

Revision [763]

Edited on 2004-07-22 21:26:05 by JsnX [pages-purge-time revised]
Additions:
''Yes, this is good discussion item. Personally, I've never used "pages_purge_time", and had not given it much thought. It seems that we need another option such as purge_keep_limit, which will specify that at least x number of page revisions should be kept. What do you think? -- JsnX''

Revision [761]

Edited on 2004-07-22 14:47:06 by DreckFehler [discussion (purging pages)]
Additions:
=====discussion=====
if the config-value "pages_purge_time" is set to another value than zero (never purge), //any// revision will be deleted if a page is untouched for a while and modified after a period greater than the purge-time. due to this it's possible to destroy old pages which aren't modified frequently without any chance to recover it.
this flaw may be covered by the mechanism used in wikka wiki to mark minor changes as non cacheble and only cleanup only those pages(?). if not, there shold be a more sophisticated use of purging in the function $wakka->maintenance. any ideas?
=====ready-to-use modifications=====
Deletions:
%%// add new revision

Revision [760]

Edited on 2004-07-22 14:15:39 by DreckFehler [list-bug]
Additions:
the following hacks and tweaks are based on WakkaWiki v. 1.2. try to figure out yourself, where to put the changes in modified code ;)
----
====bug in rendering of lists====
if a list - ordered or unordered - is put at the very begining of a page (i.e. there is no text before that list), the first item of the list will not be recognized as a list-member, because the body is trimmed before saving. the bug is located in the function $wakka->savePage().
change this code-snippet
%%(php)// add new revision
$this->Query("insert into ".$this->config["table_prefix"]."pages set ".
"tag = '".mysql_escape_string($tag)."', ".
($comment_on ? "comment_on = '".mysql_escape_string($comment_on)."', " : "").
"time = now(), ".
"owner = '".mysql_escape_string($owner)."', ".
"user = '".mysql_escape_string($user)."', ".
"latest = 'Y', ".
"body = '".mysql_escape_string(trim($body))."'");
%%
to this one
%%// add new revision
if (preg_match("/^([\t]+)(-|([1aiAI]\))?)/", $body, $matches)) $lead = $matches[1]; // save tab(s) of first list-definition, if any at the begining
$body = $lead.trim($body); //and write it back to the trimmed body
$this->Query("insert into ".$this->config["table_prefix"]."pages set ".
"tag = '".mysql_escape_string($tag)."', ".
($comment_on ? "comment_on = '".mysql_escape_string($comment_on)."', " : "").
"time = now(), ".
"owner = '".mysql_escape_string($owner)."', ".
"user = '".mysql_escape_string($user)."', ".
"latest = 'Y', ".
"body = '".mysql_escape_string($body)."'"); // <<<<<<< trim() removed! we did it already
%%

Revision [718]

Edited on 2004-07-12 20:54:30 by DreckFehler [dropped some info, cuz i cant delete]
Additions:
driving my own (german speaking) wakkawiki spin off called [[http://mindwiki.de/HomePage mindWiki]], i have been fallen in love with the straight, compact code ;)

[[http://mindwiki.de/sebastian/mail contact form]]
Deletions:
VeryLongTagWhichConfusesWakkaWikiBecauseOnlyPartsOfItWillBeStoredInThePagesTable

Revision [714]

The oldest known version of this page was created on 2004-07-12 20:16:34 by DreckFehler [dropped some info, cuz i cant delete]
Valid XHTML :: Valid CSS: :: Powered by WikkaWiki