• There's a bug in the Method()-method in wikka.php.
• The calls to strstr() and strrpos() have a wrong order of arguments. I think, it can be a security issue, since we have access to arbitrary .php-files on the server. Even user-uploaded ones...
• See fix below.
• Change line 795 in wikka.php to
• if (strstr($method,'/')) 
• And line 797 to
• $method = substr($method, strrpos($method, '/' )+1); 
• -- PhilippAHartmann

WikiEdit : Ctrl+5 executed twice

• Confirmed - we'll look into this. --JavaWoman

GetCookie() bug

Fatal error: Call to a member function on a non-object

• How about this page? Btw, annoying people from whom you want help is always a bad idea... --NilsLindenberg
  • Well, i wasn't sure if it was an actual bug or not. I thought it might be a server config issue on my part and i didn't want to clutter up this here bug page. Also, and this is totally my bad, it didn't really occur to me that it was Easter w'end and that ppl might have actual lives. Thanks to JavaWoman we snapped out a solution on irc and i added it to the page.

Problems with double double-quote html?

Description of the problem

Solution

return $this->htmlspecialchars_ent($matches[1]);

return $wakka->htmlspecialchars_ent($matches[1]);

check of user-names against page-names

Feedback Action bug

Unicode rendering buglet

Forced links Formatter bug

• JavaWoman, this does appear to take care of the described problem without effecting any existing forced links. Thanks for pointing this out. Your suggested fix has been added to Wikka 1.1.6.0. -- JsnX

WikiEdit UTF-8 Bug

• Dave, this does appear to take care of the described problem. Thanks for pointing this out. Your suggested fix has been added to Wikka 1.1.6.0. -- JsnX

Strikethrough rendering

.strikethrough {color: #888; text-decoration: line-through;}
.deletions {color: #876; background-color: #FFCC99;}

• Marking "a strikethrough" as "deletion" in order to get a certain rendering is just a roundabout way to go back to presentational markup instead of structural, semantic markup! The class should indicate its purpose (i.e., real clasification!); so if the purpose is "strikethrough" rather than "deletion", it should indeed be a separate class. In the CSS you then have the freedom to either style both classes the same, or to style them differently.
• See also my remarks about "markup of diff pages" in the SuggestionBox! -- JavaWoman
  • Yes, I have read your remarks in the SB. But this is (hopefully, as i can't test it) an easy solution for the problem, as long as it isn't modified towards your suggestions.
    
    The problem is, that there is no handling for "deletion". Instead, "strikethrough" is misused for it. To change this:

static $trigger_inserted = 0;
static $trigger_center = 0;

static $trigger_inserted = 0;
static $trigger_deleted = 0;
static $trigger_center = 0;

$trigger_bold = $trigger_center = $trigger_floatl = $trigger_inserted = $trigger_italic =$trigger_keys = 0;

$trigger_bold = $trigger_center = $trigger_floatl = $trigger_inserted = $trigger_deleted = $trigger_italic =$trigger_keys = 0;

// strikethrough
else if ($thing == "++" || $thing == "¥¥") 
{
 return (++$trigger_strike % 2 ? "<span class=\"deletions\">" : "</span>");
} 

// strikethrough
else if ($thing == "++") 
{
return (++$trigger_strike % 2 ? "<span class=\"strikethrough\">" : "</span>");
} 

// deletions
else if ($thing == "¥¥") 
{
return (++$trigger_deleted % 2 ? "<span class=\"deletions\">" : "</span>");
} 

Entering { on French keyboard

• Can you give me some more detail on this one. I'm not sure what you mean or how to replicate the bug. -- JsnX 5/27/04
• Is anyone else seeing this? -- JsnX 5/29/04
  • I have a french azerty keyboard, and to type {, I combine keys Alt Gr and 4. But when I try this inside the box, I have my line enclosed with ===, as I typed Ctrl + Shift + 4, and the character { doesn' t appear as expected! It's because of Javascript. [DotMG]
    • I'm not encountering any problems with my swedish keyboard. Can use the full range of Alt Gr symbols: @£$?{[]}\. -- JockeAndersson 6/1/04
      • Ok, I corrected it myself. wikiedit2/wikiedit2.js --DotMG:

          if (event.altKey && !event.ctrlKey) Key=Key+4096;
          if ((event.ctrlKey) && !event.altKey) Key=Key+2048;

Underline in headers

• The problem instigator is the colon on that line. As soon as the colon is removed it works fine. So, the next question is: why is it causing a problem? And the answer is, the formatter sees the colon and thinks we are trying to specify an Interwiki link. If we really trace the problem we find that this can be traced back to JavaWoman! :) Take a look at her suggestions to fix interwiki links on WikkaBugsResolved. Here's the regular expression recommended to match interwiki links:
  

   "\b[A-Z,ÄÖÜ][A-Z,a-z,ÄÖÜ,ßäöü]+[:]\S*\b|". 

  After the colon it's matching anything not whitespace. Hmm, fine and dandy, but as we see it matches the underscore and things get messed up.
• Here's what I changed it to:

   "\b[A-Z,ÄÖÜ][A-Z,a-z,ÄÖÜ,ßäöü]+[:](?![=_])\S*\b|". 

  I'm using negative lookahead to say that I don't want it to match an equal sign or underscore. You guys know I'm dangerous with regular expressions, so if someone can explain to me why this is a bad idea and recommend another solution, I'm listening. However I should note, the interwiki problem is still resolved and the underline problem is fixed also, so it seems successful. --JsnX

array_merge

if (file_exists("wakka.config.php"))
{
rename("wakka.config.php", "wikka.config.php");
} else {
$wakkaConfig = array();
} 

• Added your suggestion in Wikka 1.1.5.4. Thanks for pointing this out. -- JsnX

Interwiki is broken

• There are in fact two causes for this:
  1. the evaluation order in Link() is wrong: it evaluates a WikiName before it evaluates a possible Interwiki link; since a WikiName is a substring of an an Interwiki link, the latter should be matched first;
  2. the RE used to match an Interwiki assumes only WikiNames after the colon; since an Interwiki link actually appends a string to a pre-defined part of a URL, we should allow anything that is allowed in a URL - not just WikiNames.
• An extra complication is that the REs used are occuring in three different places - a nice case for using a central "repository" for REs in a set of define() statements rather than having them scattered all over the code!
  
  
• Without addressing the last issue of the scattered REs, the following changes will fix this problem: